selftests: devlink: fix the fd redirect in dummy_reporter_test
authorJakub Kicinski <kuba@kernel.org>
Thu, 15 Dec 2022 02:01:01 +0000 (18:01 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:55 +0000 (13:32 +0100)
commita02f965d828f8ff6be4ac2a78c323a930219949f
tree159ea3ace0c1ebfe8241aa06f1c8599c7a2088f0
parent6298cab4d80bfdb6fe01fe31fd9f0ba26317fdae
selftests: devlink: fix the fd redirect in dummy_reporter_test

[ Upstream commit 2fc60e2ff972d3dca836bff0b08cbe503c4ca1ce ]

$number + > bash means redirect FD $number, e.g. commonly
used 2> redirects stderr (fd 2). The test uses 8192> to
write the number 8192 to a file, this results in:

  ./devlink.sh: line 499: 8192: Bad file descriptor

Oddly the test also papers over this issue by checking
for failure (expecting an error rather than success)
so it passes, anyway.

Fixes: ff18176ad806 ("selftests: Add a test of large binary to devlink health test")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/drivers/net/netdevsim/devlink.sh