sctp: handle invalid error codes without calling BUG()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 9 Jun 2023 11:04:43 +0000 (14:04 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 12 Jun 2023 08:36:27 +0000 (09:36 +0100)
commita0067dfcd9418fd3b0632bc59210d120d038a9c6
tree4b623bd0686fac08075b288c9cb55932eb3dc493
parentce57adc222aba32431c42632b396e9213d0eb0b8
sctp: handle invalid error codes without calling BUG()

The sctp_sf_eat_auth() function is supposed to return enum sctp_disposition
values but if the call to sctp_ulpevent_make_authkey() fails, it returns
-ENOMEM.

This results in calling BUG() inside the sctp_side_effects() function.
Calling BUG() is an over reaction and not helpful.  Call WARN_ON_ONCE()
instead.

This code predates git.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/sm_sideeffect.c