[flang][driver] Rename the accessors/mutators (NFC)
authorAndrzej Warzynski <andrzej.warzynski@arm.com>
Wed, 28 Oct 2020 10:47:48 +0000 (10:47 +0000)
committerAndrzej Warzynski <andrzej.warzynski@arm.com>
Mon, 2 Nov 2020 10:55:13 +0000 (10:55 +0000)
commit9ffb5b0469ae593f8b7e1d7d9ef6ea46cd366e6e
tree9ad077f7293fa5996774d09fa5ab6869fc139b01
parent0df197516b69a4477a4c8f02b7c4dccacda5f23f
[flang][driver] Rename the accessors/mutators (NFC)

As per point 3 in [1]:

```
Accessor member functions are named with the non-public data member's
name, less the trailing underscore.  Mutator member functions are named
set_...
```

Originally we just followed the LLVM's style, which is incompatible with
Flang. This patch renames the accessors and mutators accordingly.

`getDiagnostics` and `GetDiagnostics` are replaced with one accessor:
`diagnostics`. `SetDiagnostics` was neither implemented nor used, so
it's deleted.

[1] https://github.com/llvm/llvm-project/blob/master/flang/docs/C++style.md#naming

Differential Revision: https://reviews.llvm.org/D90300
12 files changed:
flang/include/flang/Frontend/CompilerInstance.h
flang/include/flang/Frontend/CompilerInvocation.h
flang/include/flang/Frontend/FrontendAction.h
flang/include/flang/Frontend/FrontendOptions.h
flang/lib/Frontend/CompilerInstance.cpp
flang/lib/Frontend/CompilerInvocation.cpp
flang/lib/Frontend/FrontendAction.cpp
flang/lib/Frontend/FrontendActions.cpp
flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp
flang/tools/flang-driver/fc1_main.cpp
flang/unittests/Frontend/CompilerInstanceTest.cpp
flang/unittests/Frontend/InputOutputTest.cpp