parport_pc: release IO region properly if unsupported ITE887x card is found
authorJiri Kosina <jkosina@suse.cz>
Thu, 6 Oct 2011 21:29:48 +0000 (14:29 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 18 Oct 2011 21:17:40 +0000 (14:17 -0700)
commit9fdbdd062bfc187e2aa32f7880fa7e8ae717efdf
tree473ad879cfb805c26f6f09a7ea5d02c49e15d411
parent8193c4290620d9b2a6ac116719f11aa99053a90d
parport_pc: release IO region properly if unsupported ITE887x card is found

sio_ite_8872_probe() bails out if it detects no-parallel (1S, 2S) or
unknown card.

It doesn't call release_region() on the previously allocated resource
though.  This causes

  (a) leak of the resource
  (b) kernel oops when parport module is removed and /proc/ioports is read. This
      is because the string that has been associated to the IO port region
      is a static char array inside the already removed module.

Let's call release_region() properly before baling out.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Acked-by: Niels de Vos <ndevos@redhat.com>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Joe Krahn <krahn@niehs.nih.gov>
Signed-off-by: Andrew Morton <akpm@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/parport/parport_pc.c