cifs: do all necessary checks for credits within or before locking
authorShyam Prasad N <sprasad@microsoft.com>
Thu, 22 Jun 2023 18:16:04 +0000 (18:16 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:44 +0000 (16:21 +0200)
commit9fb981a86ae5008f05018e6ecff052b2ea9daecc
treec4738f2420b7f3974ba9c017ce5ad640d5f7ec2c
parent4fe07d55a5461e66a55fbefb57f85ff0facea32b
cifs: do all necessary checks for credits within or before locking

[ Upstream commit 326a8d04f147e2bf393f6f9cdb74126ee6900607 ]

All the server credits and in-flight info is protected by req_lock.
Once the req_lock is held, and we've determined that we have enough
credits to continue, this lock cannot be dropped till we've made the
changes to credits and in-flight count.

However, we used to drop the lock in order to avoid deadlock with
the recent srv_lock. This could cause the checks already made to be
invalidated.

Fixed it by moving the server status check to before locking req_lock.

Fixes: d7d7a66aacd6 ("cifs: avoid use of global locks for high contention data")
Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/smb2ops.c
fs/smb/client/transport.c