[Support] Fix behavior of StringRef::count with overlapping occurrences, add tests
authorJohannes Doerfert <johannes@jdoerfert.de>
Tue, 24 Dec 2019 23:25:37 +0000 (17:25 -0600)
committerJohannes Doerfert <johannes@jdoerfert.de>
Wed, 25 Dec 2019 00:30:41 +0000 (18:30 -0600)
commit9f6b13e5cce96066d7262d224c971d93c2724795
tree9c6f399d19ea75ac2270657902bfffa0042df6ae
parenta36ddf0aa9db5c1086e04f56b5f077b761712eb5
[Support] Fix behavior of StringRef::count with overlapping occurrences, add tests

Summary:
Fix the behavior of StringRef::count(StringRef) to not count overlapping occurrences, as is stated in the documentation.
Fixes bug https://bugs.llvm.org/show_bug.cgi?id=44072

I added Krzysztof Parzyszek to review this change because a use of this function in HexagonInstrInfo::getInlineAsmLength might depend on the overlapping-behavior. I don't have enough domain knowledge to tell if this change could break anything there.

All other uses of this method in LLVM (besides the unit tests) only use single-character search strings. In those cases, search occurrences can not overlap anyway.

Patch by Benno (@Bensge)

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D70585
llvm/lib/Support/StringRef.cpp
llvm/unittests/ADT/StringRefTest.cpp