ASoC: SOF: Intel: hda-dsp: simplify S3 resume flows
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 17 Oct 2022 20:49:46 +0000 (15:49 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 18 Oct 2022 18:16:33 +0000 (19:16 +0100)
commit9f68d6e64f51bf62f8d2f7d82a425470e9aa3b24
treef676c620615e688b85bcdf4c0d08dda98ef5016d
parent8e1ae6f62c7e8f904949e9c60a4a38715c8c0aff
ASoC: SOF: Intel: hda-dsp: simplify S3 resume flows

The flow contains surprising parts that seem to have been inspired by
the Skylake driver.

During a resume from S3, the state of the links prior to suspend
should not matter. One would have to assume that the links are powered
down anyways prior to suspend, and there is also no specific code that
turns links on unconditionally on resume.

Likewise, the snd_hdac_init_chip() routine will start the cmd_io
handling, and it's not clear why we should care about the state of the
DMA prior to suspend.

This patch removes these two sequences to simplify the flow.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20221017204946.207986-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda-dsp.c