tcp: add a scheduling point in established_get_first()
authorJian Wen <wenjianhn@gmail.com>
Tue, 11 Jul 2023 03:24:05 +0000 (11:24 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 12 Jul 2023 21:47:31 +0000 (14:47 -0700)
commit9f4a7c930284bf2b5b84d3636a8e88857149328f
treef57056fb61c4bec3ed731a3b8654e26adfabb34e
parente0f0a5db5f8c413cbbf48607f711c2a21023ee66
tcp: add a scheduling point in established_get_first()

Kubernetes[1] is going to stick with /proc/net/tcp for a while.

This commit reduces the scheduling latency introduced by
established_get_first(), similar to commit acffb584cda7 ("net: diag:
add a scheduling point in inet_diag_dump_icsk()").

In our environment, the scheduling latency affects the performance of
latency-sensitive services like Redis.

Changes in V2 :
 - call cond_resched() before checking if a bucket is empty as
   suggested by Eric Dumazet
 - removed the delay of synchronize_net() from the commit message

[1] https://github.com/google/cadvisor/blob/v0.47.2/container/libcontainer/handler.go#L130

Signed-off-by: Jian Wen <wenjian1@xiaomi.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230711032405.3253025-1-wenjian1@xiaomi.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/tcp_ipv4.c