vti6: remove !skb->ignore_df check from vti6_xmit()
authorAlexey Kodanev <alexey.kodanev@oracle.com>
Thu, 23 Aug 2018 16:49:54 +0000 (19:49 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 30 Aug 2018 00:51:44 +0000 (17:51 -0700)
commit9f2895461439fda2801a7906fb4c5fb3dbb37a0a
treedfd663463f8853ef193b3bfc5b80738fd89a17d9
parent6a5d39aa9ac274d9ccdb50ec47112158537f00de
vti6: remove !skb->ignore_df check from vti6_xmit()

Before the commit d6990976af7c ("vti6: fix PMTU caching and reporting
on xmit") '!skb->ignore_df' check was always true because the function
skb_scrub_packet() was called before it, resetting ignore_df to zero.

In the commit, skb_scrub_packet() was moved below, and now this check
can be false for the packet, e.g. when sending it in the two fragments,
this prevents successful PMTU updates in such case. The next attempts
to send the packet lead to the same tx error. Moreover, vti6 initial
MTU value relies on PMTU adjustments.

This issue can be reproduced with the following LTP test script:
    udp_ipsec_vti.sh -6 -p ah -m tunnel -s 2000

Fixes: ccd740cbc6e0 ("vti6: Add pmtu handling to vti6_xmit.")
Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ip6_vti.c