slab: Remove __malloc attribute from realloc functions
authorKees Cook <keescook@chromium.org>
Fri, 23 Sep 2022 20:28:07 +0000 (13:28 -0700)
committerVlastimil Babka <vbabka@suse.cz>
Thu, 29 Sep 2022 09:05:57 +0000 (11:05 +0200)
commit9ed9cac1850a2a55674b4a17100c50b46f645921
tree4b971acef7344c8d2910c0a25032635ce8e83c0f
parente45cc288724f0cfd497bb5920bcfa60caa335729
slab: Remove __malloc attribute from realloc functions

The __malloc attribute should not be applied to "realloc" functions, as
the returned pointer may alias the storage of the prior pointer. Instead
of splitting __malloc from __alloc_size, which would be a huge amount of
churn, just create __realloc_size for the few cases where it is needed.

Thanks to Geert Uytterhoeven <geert@linux-m68k.org> for reporting build
failures with gcc-8 in earlier version which tried to remove the #ifdef.
While the "alloc_size" attribute is available on all GCC versions, I
forgot that it gets disabled explicitly by the kernel in GCC < 9.1 due
to misbehaviors. Add a note to the compiler_attributes.h entry for it.

Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: Marco Elver <elver@google.com>
Cc: linux-mm@kvack.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
include/linux/compiler_attributes.h
include/linux/compiler_types.h
include/linux/slab.h
mm/slab_common.c