usb: usbip: fix a refcount leak in stub_probe()
authorHangyu Hua <hbh25y@gmail.com>
Tue, 12 Apr 2022 02:02:57 +0000 (10:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Apr 2022 17:01:22 +0000 (19:01 +0200)
commit9ec4cbf1cc55d126759051acfe328d489c5d6e60
treebf8f11553b9afc6838897197425a1ef022710796
parente8784c0aec03a2581ee55827ba694e129d6a57ad
usb: usbip: fix a refcount leak in stub_probe()

usb_get_dev() is called in stub_device_alloc(). When stub_probe() fails
after that, usb_put_dev() needs to be called to release the reference.

Fix this by moving usb_put_dev() to sdev_free error path handling.

Find this by code review.

Fixes: 3ff67445750a ("usbip: fix error handling in stub_probe()")
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20220412020257.9767-1-hbh25y@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usbip/stub_dev.c