media: vidtv: remove an impossible condition
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 17 Sep 2020 09:48:17 +0000 (11:48 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 17 Sep 2020 10:03:36 +0000 (12:03 +0200)
commit9e76f2cff7a17af92c819ca0489ec5399f8367f7
tree4db356952da52e0f9491deaf2169880036a3c2c2
parentad458524b3fa2cef0b322984591bbdfd527367c3
media: vidtv: remove an impossible condition

As warned by smatch:

drivers/media/test-drivers/vidtv/vidtv_psi.c:93 vidtv_psi_update_version_num() warn: impossible condition '(h->version > 32) => (0-31 > 32)'

h_version is declared as:

u8  version:5;

Meaning that its value ranges from 0 to 31. Incrementing 31 on such
data will overflow to zero, as expected.

So, just drop the uneeded overflow check.

While here, use "foo++" instead of "++foo", as this is a much
more common pattern.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/test-drivers/vidtv/vidtv_psi.c