bna: Avoid reading past end of buffer
authorKees Cook <keescook@chromium.org>
Fri, 5 May 2017 22:25:32 +0000 (15:25 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 May 2017 18:41:41 +0000 (14:41 -0400)
commit9e4eb1ce472fbf7b007f23c88ec11c37265e401c
treec98e366cdbadd084541b6722371b68af37a9d4f6
parent8403debeead8e8b296d7a7db2174af524695ab42
bna: Avoid reading past end of buffer

Using memcpy() from a string that is shorter than the length copied means
the destination buffer is being filled with arbitrary data from the kernel
rodata segment. Instead, use strncpy() which will fill the trailing bytes
with zeros.

This was found with the future CONFIG_FORTIFY_SOURCE feature.

Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/brocade/bna/bfa_ioc.c