x86/dumpstack: Improve opcodes dumping in the code section
authorBorislav Petkov <bp@suse.de>
Tue, 17 Apr 2018 16:11:19 +0000 (18:11 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 26 Apr 2018 14:15:26 +0000 (16:15 +0200)
commit9e4a90fd34445df64a13d136676a31a4dd22aea3
treea96285cddfc8bdaba453443ab9bfb7a4b1c5c6fb
parentf0a1d7c11c3ebe2f601b448d13e7fbc3a0364a03
x86/dumpstack: Improve opcodes dumping in the code section

The code used to iterate byte-by-byte over the bytes around RIP and that
is expensive: disabling pagefaults around it, copy_from_user, etc...

Make it read the whole buffer of OPCODE_BUFSIZE size in one go. Use a
statically allocated 64 bytes buffer so that concurrent show_opcodes()
do not interleave in the output even though in the majority of the cases
it's serialized via die_lock. Except the #PF path which doesn't...

Also, do the PAGE_OFFSET check outside of the function because latter
will be reused in other context.

Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Link: https://lkml.kernel.org/r/20180417161124.5294-5-bp@alien8.de
arch/x86/kernel/dumpstack.c