Power8 inline assembly fixes
authorMartin Kroeker <martin@ruby.chemie.uni-freiburg.de>
Mon, 13 Feb 2017 22:38:50 +0000 (23:38 +0100)
committerGitHub <noreply@github.com>
Mon, 13 Feb 2017 22:38:50 +0000 (23:38 +0100)
commit9e2f316ede9ee12441e9eb30784ceb653295b80a
tree12b79569789fe6f7c1a95241b0665b33d70aa532
parente2489c9a92483dbcbcda289ac1431d09fe2f2aa2
Power8 inline assembly fixes

Quoting patch author amodra from #1078
Lots of issues here.
- The vsx regs weren't listed as clobbered.
- Poor choice of vsx regs, which along with the lack of clobbers led to
  trashing v0..v21 and fr14..fr23.  Ideally you'd let gcc choose all
  temp vsx regs, but asms currently have a limit of 30 i/o parms.
- Other regs were clobbered unnecessarily, seemingly in an attempt to
  clobber inputs, with gcc-7 complaining about the clobber of r2.
  (Changed inputs should be also listed as outputs or as an i/o.)
- "r" constraint used instead of "b" for gprs used in insns where the
  r0 encoding means zero rather than r0.
- There were unused asm inputs too.
- All memory was clobbered rather than hooking up memory outputs with
  proper memory constraints, and that and the lack of proper memory
  input constraints meant the asms needed to be volatile and their
  containing function noinline.
- Some parameters were being passed unnecessarily via memory.
- When a copy of a
38 files changed:
kernel/power/casum.c
kernel/power/casum_microk_power8.c
kernel/power/ccopy_microk_power8.c
kernel/power/cswap_microk_power8.c
kernel/power/dasum.c
kernel/power/dasum_microk_power8.c
kernel/power/daxpy.c
kernel/power/daxpy_microk_power8.c
kernel/power/dcopy_microk_power8.c
kernel/power/ddot.c
kernel/power/ddot_microk_power8.c
kernel/power/dgemv_n.c
kernel/power/dgemv_n_microk_power8.c
kernel/power/drot.c
kernel/power/drot_microk_power8.c
kernel/power/dscal.c
kernel/power/dscal_microk_power8.c
kernel/power/dswap_microk_power8.c
kernel/power/sasum.c
kernel/power/sasum_microk_power8.c
kernel/power/scopy_microk_power8.c
kernel/power/sdot.c
kernel/power/sdot_microk_power8.c
kernel/power/srot.c
kernel/power/srot_microk_power8.c
kernel/power/sscal.c
kernel/power/sscal_microk_power8.c
kernel/power/sswap_microk_power8.c
kernel/power/zasum.c
kernel/power/zasum_microk_power8.c
kernel/power/zaxpy.c
kernel/power/zaxpy_microk_power8.c
kernel/power/zcopy_microk_power8.c
kernel/power/zdot.c
kernel/power/zdot_microk_power8.c
kernel/power/zscal.c
kernel/power/zscal_microk_power8.c
kernel/power/zswap_microk_power8.c