Discard unused locals cleanup (dotnet/corefx#41876)
authorKevin Jones <kevin@vcsjones.com>
Fri, 18 Oct 2019 21:36:26 +0000 (17:36 -0400)
committerStephen Toub <stoub@microsoft.com>
Fri, 18 Oct 2019 21:36:26 +0000 (17:36 -0400)
commit9e11430a66ada7383dac5302e7a6b73a26e37c39
tree5534553ec325ed825782900e3a14874893870bd7
parenta66a19865cea49b8af61a50d22363c272c30d944
Discard unused locals cleanup (dotnet/corefx#41876)

* Discard result from GetC14NDigest.

GetC14NDigest is being used to update the `hashAlg` from the
`GetDigestedOutput`, as well as update the `_digestedSignedInfo` and
cache flag. The return value is not needed. Discard it to make that
clearer.

* Discard the result from `CertControlStore`.

The comment above the change explains the reason for discarding
the result.

* Ignore result from CryptAcquireContext.

The comment below justifies the reason for ignoring the local.

* Code review feedback.

Commit migrated from https://github.com/dotnet/corefx/commit/ef8756c03ff3808e2b065e6cf5c07aa169ac868f
src/libraries/Common/src/Interop/Windows/Advapi32/SafeProvHandle.cs
src/libraries/System.Security.Cryptography.X509Certificates/src/Internal/Cryptography/Pal.Windows/StorePal.Import.cs
src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXml.cs