Web Inspector: paint box model colors in Metrics sidebar at all times, do not draw...
authorpfeldman@chromium.org <pfeldman@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Sep 2011 13:33:10 +0000 (13:33 +0000)
committerpfeldman@chromium.org <pfeldman@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Sep 2011 13:33:10 +0000 (13:33 +0000)
commit9df342d3265fbd7f5e467276a0c1ce68b8f6e4ea
treef153b29560af4a5d067e7da8cbdc0f8d3fd2a84a
parent3eda845c1352d12bfc0c7dbedc96d51f677268b4
Web Inspector: paint box model colors in Metrics sidebar at all times, do not draw box outlines.
https://bugs.webkit.org/show_bug.cgi?id=68240

Today we paint backgrounds in Metrics box model on hover only - should be painted at all
times for the reference. Outlining boxes is highlight is wrong since outlines are outside
the corresponding box regions. We've seen few reports on that + Firebug does not do borders
for that reason.

Reviewed by Yury Semikhatsky.

* inspector/DOMNodeHighlighter.cpp:
* inspector/DOMNodeHighlighter.h:
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
* inspector/front-end/Color.js:
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
(WebInspector.MetricsSidebarPane.prototype._updateMetrics):
* inspector/front-end/inspector.css:
(.metrics .label):
* inspector/front-end/inspector.js:
(WebInspector.buildHighlightConfig):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/inspector/DOMNodeHighlighter.cpp
Source/WebCore/inspector/DOMNodeHighlighter.h
Source/WebCore/inspector/Inspector.json
Source/WebCore/inspector/InspectorDOMAgent.cpp
Source/WebCore/inspector/front-end/Color.js
Source/WebCore/inspector/front-end/MetricsSidebarPane.js
Source/WebCore/inspector/front-end/inspector.css
Source/WebCore/inspector/front-end/inspector.js