fbdev: sm712fb: fix memory frequency by avoiding a switch/case fallthrough
authorYifeng Li <tomli@tomli.me>
Tue, 2 Apr 2019 15:14:10 +0000 (17:14 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tue, 2 Apr 2019 15:14:10 +0000 (17:14 +0200)
commit9dc20113988b9a75ea6b3abd68dc45e2d73ccdab
tree73a4063d202b12931e0eaeb3132feb777fb538fb
parentcf84807f6dd0be5214378e66460cfc9187f532f9
fbdev: sm712fb: fix memory frequency by avoiding a switch/case fallthrough

A fallthrough in switch/case was introduced in f627caf55b8e ("fbdev:
sm712fb: fix crashes and garbled display during DPMS modesetting"),
due to my copy-paste error, which would cause the memory clock frequency
for SM720 to be programmed to SM712.

Since it only reprograms the clock to a different frequency, it's only
a benign issue without visible side-effect, so it also evaded Sudip
Mukherjee's code review and regression tests. scripts/checkpatch.pl
also failed to discover the issue, possibly due to nested switch
statements.

This issue was found by Stephen Rothwell by building linux-next with
-Wimplicit-fallthrough.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: f627caf55b8e ("fbdev: sm712fb: fix crashes and garbled display during DPMS modesetting")
Signed-off-by: Yifeng Li <tomli@tomli.me>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/sm712fb.c