[GDBRemote] Remove code that flushes GDB remote packets
authorJonas Devlieghere <jonas@devlieghere.com>
Fri, 28 Jun 2019 18:14:27 +0000 (18:14 +0000)
committerJonas Devlieghere <jonas@devlieghere.com>
Fri, 28 Jun 2019 18:14:27 +0000 (18:14 +0000)
commit9db6073381da617bea6c117d02fd0b0d30d33c4b
tree343990335d4be9e3eb712c8a8dd4e04563a6d94f
parent7d78e5cc81150ce8bddb53dcbb4f70e3ee409882
[GDBRemote] Remove code that flushes GDB remote packets

The arbitrary timeout when flushing GDB remote packets caused
non-determinism and flakiness between test runs. I suspect it is what's
causing the flakiness of the reproducer tests on GreenDragon, and want
to see if removing it causes that to go away.

This change was originally introduced in r197579 to discard a
`$T02thread:01;#4` that QEMU was sending. If anybody knows how to test
that this continues working after removing this code, I'd love to hear
it.

llvm-svn: 364669
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp