mt76: mt7615: Use after free in mt7615_mcu_set_bcn()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 3 May 2019 13:09:13 +0000 (16:09 +0300)
committerFelix Fietkau <nbd@nbd.name>
Tue, 25 Jun 2019 10:55:25 +0000 (12:55 +0200)
commit9db1aec0c2d72a3b7b115ba56e8dbb5b46855333
treee9029b71a2a93803743a0bfc6f9020709bfaf9d6
parentb1571a0e77d8cef14227af293c6dda1464a57270
mt76: mt7615: Use after free in mt7615_mcu_set_bcn()

We dereference "skb" when we assign:

req.pkt_len = cpu_to_le16(MT_TXD_SIZE + skb->len);
                                                ^^^^^^^^
So this patch just moves the dev_kfree_skb() down a bit to avoid the
use after free.

Fixes: 04b8e65922f6 ("mt76: add mac80211 driver for MT7615 PCIe-based chipsets")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c