scsi: pm80xx: Free the tag when mpi_set_phy_profile_resp is received
authoryuuzheng <yuuzheng@google.com>
Mon, 16 Mar 2020 07:49:03 +0000 (13:19 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 17 Mar 2020 17:57:16 +0000 (13:57 -0400)
commit9d9c7c20fb35444fe26bf284fb89006fd7767ab7
treee89b093c1766ece9214eb5ea69a66dab5dac1ae7
parentd384be6ede5caa22e8d34dc89949b987c4f44381
scsi: pm80xx: Free the tag when mpi_set_phy_profile_resp is received

In pm80xx driver, the command mpi_set_phy_profile_req is sent by host
during boot to configure the phy profile such as analog setting page, rate
control page. However, the tag is not freed when its response is
received. As a result, 16 tags are missing for each HBA after boot.  When
NCQ is enabled with queue depth 16, it needs at least, 15 * 16 = 240 tags
for each HBA to achieve the best performance. In current pm80xx driver with
setting CCB_MAX = 256, the total number of tags in each HBA is 255 for data
IO. Hence, without returning those tags to the pool after boot, some device
will finally be forced to non-ncq mode by ATA layer due to excessive errors
(i.e. LLDD cannot allocate tag for queued task).

Link: https://lore.kernel.org/r/20200316074906.9119-4-deepak.ukey@microchip.com
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: yuuzheng <yuuzheng@google.com>
Signed-off-by: Deepak Ukey <deepak.ukey@microchip.com>
Signed-off-by: Viswas G <Viswas.G@microchip.com>
Signed-off-by: Radha Ramachandran <radha@google.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm80xx_hwi.c