remoteproc: sysmon: fix shutdown_acked state
authorArnd Bergmann <arnd@arndb.de>
Fri, 4 Dec 2020 19:37:35 +0000 (20:37 +0100)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Fri, 4 Dec 2020 22:40:52 +0000 (16:40 -0600)
commit9d7b4a40387d0f91512a74caed6654ffa23d5ce4
treeca86e45233f74aca868a792e8ad47004e8125850
parentc3c21b356505e2f4c528d22903531f7764e18998
remoteproc: sysmon: fix shutdown_acked state

The latest version of sysmon_stop() starts by initializing
the sysmon->shutdown_acked variable, but then overwrites it
with an uninitialized variable later:

drivers/remoteproc/qcom_sysmon.c:551:11: error: variable 'acked' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
        else if (sysmon->ept)
                 ^~~~~~~~~~~
drivers/remoteproc/qcom_sysmon.c:554:27: note: uninitialized use occurs here
        sysmon->shutdown_acked = acked;
                                 ^~~~~

Remove the local 'acked' variable again and set the state directly.

Fixes: 5c212aaf5457 ("remoteproc: sysmon: Expose the shutdown result")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20201204193740.3162065-1-arnd@kernel.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_sysmon.c