scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 23 May 2020 10:11:29 +0000 (13:11 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 26 May 2020 19:54:39 +0000 (15:54 -0400)
commit9d7464b18892332e35ff37f0b024429a1a9835e6
treeccad8981cb88f58af183191de83c95ff157835f0
parent5ae6a6a915033bfee79e76e0c374d4f927909edc
scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd()

The pr_debug() dereferences "cmd" after we already freed it by calling
tcmu_free_cmd(cmd).  The debug printk needs to be done earlier.

Link: https://lore.kernel.org/r/20200523101129.GB98132@mwanda
Fixes: 61fb24822166 ("scsi: target: tcmu: Userspace must not complete queued commands")
Reviewed-by: Mike Christie <mchristi@redhat.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_user.c