SkThreadPool ~~> SkTaskGroup
authormtklein <mtklein@chromium.org>
Wed, 3 Sep 2014 21:06:47 +0000 (14:06 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 3 Sep 2014 21:06:48 +0000 (14:06 -0700)
commit9c7207b5dc71dc5a96a2eb107d401133333d5b6f
treed4a19230e5516cb03513c5ad15ab9779dc3eeac0
parent00b76bd750e668a6989dd497313e715d1b476fdc
SkThreadPool ~~> SkTaskGroup

SkTaskGroup is like SkThreadPool except the threads stay in
one global pool.  Each SkTaskGroup itself is tiny (4 bytes)
and its wait() method applies only to tasks add()ed to that
instance, not the whole thread pool.

This means we don't need to bring up new thread pools when
tests themselves want to use multithreading (e.g. pathops,
quilt).  We just create a new SkTaskGroup and wait for that
to complete.  This should be more efficient, and allow us
to expand where we use threads to really latency sensitive
places.  E.g. we can probably now use these in nanobench
for CPU .skp rendering.

Now that all threads are sharing the same pool, I think we
can remove most of the custom mechanism pathops tests use
to control threading.  They'll just ride on the global pool
with all other tests now.

This (temporarily?) removes the GPU multithreading feature
from DM, which we don't use.

On my desktop, DM runs a little faster (57s -> 55s) in
Debug, and a lot faster in Release (36s -> 24s).  The bots
show speedups of similar proportions, cutting more than a
minute off the N4/Release and Win7/Debug runtimes.

BUG=skia:
R=caryclark@google.com, bsalomon@google.com, bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/531653002
42 files changed:
dm/DM.cpp
dm/DMQuiltTask.cpp
dm/DMTask.cpp
dm/DMTask.h
dm/DMTaskRunner.cpp
dm/DMTaskRunner.h
dm/DMTestTask.cpp
dm/DMTestTask.h
gyp/dm.gypi
gyp/pathops_skpclip.gyp
gyp/pathops_unittest.gyp
gyp/tools.gyp
gyp/utils.gypi
src/utils/SkRunnable.h
src/utils/SkTaskGroup.cpp [new file with mode: 0644]
src/utils/SkTaskGroup.h [new file with mode: 0644]
src/utils/SkThreadPool.h [deleted file]
tests/OnceTest.cpp
tests/PathOpsExtendedTest.cpp
tests/PathOpsExtendedTest.h
tests/PathOpsOpCubicThreadedTest.cpp
tests/PathOpsOpLoopThreadedTest.cpp
tests/PathOpsOpRectThreadedTest.cpp
tests/PathOpsQuadLineIntersectionThreadedTest.cpp
tests/PathOpsSimplifyDegenerateThreadedTest.cpp
tests/PathOpsSimplifyQuadThreadedTest.cpp
tests/PathOpsSimplifyQuadralateralsThreadedTest.cpp
tests/PathOpsSimplifyRectThreadedTest.cpp
tests/PathOpsSimplifyTrianglesThreadedTest.cpp
tests/PathOpsSkpClipTest.cpp
tests/PathOpsThreadedCommon.cpp
tests/PathOpsThreadedCommon.h
tests/PathOpsTightBoundsTest.cpp
tests/SkpSkGrTest.cpp
tests/Test.cpp
tests/Test.h
tests/skia_test.cpp
tools/flags/SkCommonFlags.cpp
tools/flags/SkCommonFlags.h
tools/iOSShell.cpp
tools/skpdiff/SkDiffContext.cpp
tools/valgrind.supp