Don't assume break/continue inside a TRY block works
authorPedro Alves <palves@redhat.com>
Thu, 29 Oct 2015 12:55:01 +0000 (12:55 +0000)
committerPedro Alves <palves@redhat.com>
Thu, 29 Oct 2015 12:55:01 +0000 (12:55 +0000)
commit9c6595ab6873e15fe533b05bb7b98c11f17c5d57
treed143151526b9e32b0915c8004d81830e167bc319
parentf82aa1657b7254ab634bfcce7354770478c31686
Don't assume break/continue inside a TRY block works

In C++, this:

try
  {
    break;
  }
catch (..)
  {}

is invalid.  However, because our TRY/CATCH macros support it in C,
the C++ version of those macros support it too.  To catch such
assumptions, this adds a (disabled) hack that maps TRY/CATCH to raw
C++ try/catch.  Then it goes through all instances that building on
x86_64 GNU/Linux trips on, fixing them.

This isn't strictly necessary yet, but I think it's nicer to try to
keep the tree in a state where it's easier to eliminate the TRY/CATCH
macros.

gdb/ChangeLog:
2015-10-29  Pedro Alves  <palves@redhat.com>

* dwarf2-frame-tailcall.c (dwarf2_tailcall_sniffer_first): Don't
assume that "break" breaks out of a TRY/CATCH.
* python/py-framefilter.c (py_print_single_arg): Don't assume
"continue" breaks out of a TRY/CATCH.
* python/py-value.c (valpy_binop_throw): New function, factored
out from ...
(valpy_binop): ... this.
(valpy_richcompare_throw): New function, factored
out from ...
(valpy_richcompare): ... this.
* solib.c (solib_read_symbols): Don't assume "break" breaks out
of a TRY/CATCH.
* common/common-exceptions.h [USE_RAW_CXX_TRY]
<TRY/CATCH/END_CATCH>: Define as 1-1 wrappers around try/catch.
gdb/ChangeLog
gdb/common/common-exceptions.h
gdb/dwarf2-frame-tailcall.c
gdb/python/py-framefilter.c
gdb/python/py-value.c
gdb/solib.c