Initialize strtok_r's saveptr to NULL
authorManish Goregaokar <manish@mozilla.com>
Wed, 29 Jun 2016 11:39:43 +0000 (17:09 +0530)
committerManish Goregaokar <manish@mozilla.com>
Wed, 29 Jun 2016 14:37:14 +0000 (20:07 +0530)
commit9bf74fb27dc6e2a9679403d66fe919215e3c2a45
tree95db5b24998feaec1d4364a785807351beee334e
parent28244707d9e4f35cab1f9069cee1d44b38be095f
Initialize strtok_r's saveptr to NULL

Building gdb with --enable-build-with-cxx=no trips on a warning:

 ../../binutils-gdb/gdb/rust-lang.c:173:15: error: saveptr may be used
 uninitialized in this function [-Werror=maybe-uninitialized]
     ret.name = concat (TYPE_NAME (type), "::", token, (char *) NULL);

The problem is that gcc doesn't understand that "tail" can never be
NULL in the call to strtok_r:

      name = xstrdup (TYPE_FIELD_NAME (type, 0));
      cleanup = make_cleanup (xfree, name);
      tail = name + strlen (RUST_ENUM_PREFIX);
...
      for (token = strtok_r (tail, "$", &saveptr);

Fix this by always initializing saveptr.

2016-06-29  Manish Goregaokar  <manish@mozilla.com>

gdb/ChangeLog:
    * rust-lang.c (rust_get_disr_info): Initialize saveptr to NULL.
gdb/ChangeLog
gdb/rust-lang.c