review.tizen.org Git - platform/upstream/dotnet/runtime.git/commit

projects / platform / upstream / dotnet / runtime.git / commit

author	Ganbarukamo41 <ganbarukamo@gmail.com>
	Sun, 28 Jul 2019 22:47:52 +0000 (07:47 +0900)
committer	Dan Moseley <danmose@microsoft.com>
	Sun, 28 Jul 2019 22:47:52 +0000 (15:47 -0700)
commit	9be9c570be8b057d019aca99dc2acc87dda466df
tree	bfc8a41ba199c779ef33bb378d00b1767e0dacd2	tree \| snapshot
parent	0d73813e42f1e14741d24c4d0133dc3f89866e42	commit \| diff

Enable analyzer for xUnit2000 (Constants and literals should be the expected argument) (dotnet/corefx#39842)

* Enable xUnit2000 analyzer

This commit enables xUnit2000 (Constants and literals should be the expected argument) and apply fixes for the existing violating codes.
* a Massive commit fixing xUnit2000
* fixing some 2003 errors

* Fix mistakes

* Fix missed errors for unix

Commit migrated from https://github.com/dotnet/corefx/commit/93d7aa1c1737b6da29d04b78557215e18eb786d4

189 files changed:

src/libraries/CodeAnalysis.ruleset		diff \| blob \| history
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs		diff \| blob \| history
src/libraries/Common/tests/Tests/System/StringTests.cs		diff \| blob \| history
src/libraries/Common/tests/Tests/System/Text/ValueStringBuilderTests.cs		diff \| blob \| history
src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/FileSystemTests.cs		diff \| blob \| history
src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/MyServices/FileSystemProxyTests.cs		diff \| blob \| history
src/libraries/System.Buffers/tests/ArrayPool/UnitTests.cs		diff \| blob \| history
src/libraries/System.Collections.Concurrent/tests/ConcurrentQueueTests.cs		diff \| blob \| history
src/libraries/System.Collections.NonGeneric/tests/HashtableTests.cs		diff \| blob \| history
src/libraries/System.Collections.NonGeneric/tests/SortedListTests.cs		diff \| blob \| history
src/libraries/System.Collections/tests/Generic/List/List.Generic.Tests.Misc.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderUnitTests.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AdvancedValueComposition.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/INotifyImportTests.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServiceExportFactoryTests.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTests.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/InitializationScopeTests.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataViewProviderTests.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePartTests.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/SampleComponents.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition/tests/System/Integration/RecompositionTests.cs		diff \| blob \| history
src/libraries/System.ComponentModel.TypeConverter/tests/NullableConverterTests.cs		diff \| blob \| history
src/libraries/System.Composition.Convention/tests/ExportBuilderTests.cs		diff \| blob \| history
src/libraries/System.Composition.Convention/tests/ExportBuilderUnitTests.cs		diff \| blob \| history
src/libraries/System.Composition/tests/CircularityTests.cs		diff \| blob \| history
src/libraries/System.Composition/tests/LightContainerTests.cs		diff \| blob \| history
src/libraries/System.Composition/tests/MetadataTests.cs		diff \| blob \| history
src/libraries/System.Composition/tests/SharingTests.cs		diff \| blob \| history
src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/TimeSpanValidatorAttributeTests.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/Common/DbProviderFactoriesTests.netcoreapp.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/DataRelationCollectionTest2.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/DataRowCollectionTest2.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/DataRowTest2.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/DataSetTest.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/DataTableLoadRowTest.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/DataTableTest2.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/DataViewTest.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/SqlTypes/SqlBytesTest.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/SqlTypes/SqlCharsTest.cs		diff \| blob \| history
src/libraries/System.Data.Common/tests/System/Data/SqlTypes/SqlInt32Test.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/tests/FunctionalTests/CloneTests.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/ParametersTest.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/tests/ManualTests/SQL/TransactionTest/TransactionTest.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/tests/ManualTests/SQL/UdtTest/SqlServerTypesTest.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/tests/ManualTests/SQL/WeakRefTest/WeakRefTest.cs		diff \| blob \| history
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs		diff \| blob \| history
src/libraries/System.Diagnostics.DiagnosticSource/tests/DiagnosticSourceTests.cs		diff \| blob \| history
src/libraries/System.Diagnostics.DiagnosticSource/tests/HttpHandlerDiagnosticListenerTests.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/Harness/EventTestHarness.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestEventCounter.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsTraits.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsUserErrors.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsWrite.Etw.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsWrite.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsWriteEvent.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/tests/System/DirectoryServices/ActiveDirectory/ActiveDirectoryTests.cs		diff \| blob \| history
src/libraries/System.Drawing.Common/tests/Drawing2D/GraphicsPathTests.cs		diff \| blob \| history
src/libraries/System.Globalization.Calendars/tests/Misc/Calendars.cs		diff \| blob \| history
src/libraries/System.Globalization.Extensions/tests/IdnMapping/IdnMappingGetAsciiTests.cs		diff \| blob \| history
src/libraries/System.Globalization/tests/System/Globalization/CharUnicodeInfoTests.cs		diff \| blob \| history
src/libraries/System.IO.FileSystem.AccessControl/tests/DirectoryObjectSecurityTests.cs		diff \| blob \| history
src/libraries/System.IO.FileSystem.AccessControl/tests/FileSystemAuditRuleTests.cs		diff \| blob \| history
src/libraries/System.IO.FileSystem.DriveInfo/tests/DriveInfo.Windows.Tests.cs		diff \| blob \| history
src/libraries/System.IO.Packaging/tests/Tests.cs		diff \| blob \| history
src/libraries/System.IO.UnmanagedMemoryStream/tests/UmsReadWrite.cs		diff \| blob \| history
src/libraries/System.IO/tests/StreamReader/StreamReaderTests.cs		diff \| blob \| history
src/libraries/System.IO/tests/TextReader/TextReaderTests.cs		diff \| blob \| history
src/libraries/System.Json/tests/System/Json/JsonValueTests.cs		diff \| blob \| history
src/libraries/System.Linq.Expressions/tests/Dynamic/ExpandoObjectTests.cs		diff \| blob \| history
src/libraries/System.Linq.Expressions/tests/Lambda/LambdaTests.cs		diff \| blob \| history
src/libraries/System.Linq.Expressions/tests/SequenceTests/SequenceTests.cs		diff \| blob \| history
src/libraries/System.Linq.Expressions/tests/Switch/SwitchTests.cs		diff \| blob \| history
src/libraries/System.Linq/tests/RangeTests.cs		diff \| blob \| history
src/libraries/System.Linq/tests/RepeatTests.cs		diff \| blob \| history
src/libraries/System.Memory/tests/MemoryMarshal/AsReadOnlyRef.cs		diff \| blob \| history
src/libraries/System.Memory/tests/MemoryMarshal/AsRef.cs		diff \| blob \| history
src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceTests.byte.cs		diff \| blob \| history
src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceTests.char.cs		diff \| blob \| history
src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.DefaultProxyCredentials.cs		diff \| blob \| history
src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs		diff \| blob \| history
src/libraries/System.Net.Mail/tests/Functional/MailAddressTest.cs		diff \| blob \| history
src/libraries/System.Net.Mail/tests/Functional/MailMessageTest.cs		diff \| blob \| history
src/libraries/System.Net.Primitives/tests/FunctionalTests/DnsEndPointTest.cs		diff \| blob \| history
src/libraries/System.Net.Primitives/tests/FunctionalTests/IPAddressTest.cs		diff \| blob \| history
src/libraries/System.Net.Requests/tests/FtpWebRequestTest.cs		diff \| blob \| history
src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs		diff \| blob \| history
src/libraries/System.Net.Sockets/tests/FunctionalTests/AgnosticListenerTest.cs		diff \| blob \| history
src/libraries/System.Net.Sockets/tests/FunctionalTests/DualModeSocketTest.cs		diff \| blob \| history
src/libraries/System.Net.Sockets/tests/FunctionalTests/IPPacketInformationTest.cs		diff \| blob \| history
src/libraries/System.Net.Sockets/tests/FunctionalTests/LingerStateTest.cs		diff \| blob \| history
src/libraries/System.Net.Sockets/tests/FunctionalTests/SelectTest.cs		diff \| blob \| history
src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive.cs		diff \| blob \| history
src/libraries/System.Numerics.Vectors/tests/Vector2Tests.cs		diff \| blob \| history
src/libraries/System.Numerics.Vectors/tests/Vector3Tests.cs		diff \| blob \| history
src/libraries/System.Numerics.Vectors/tests/Vector4Tests.cs		diff \| blob \| history
src/libraries/System.Private.Uri/tests/ExtendedFunctionalTests/UriTests.cs		diff \| blob \| history
src/libraries/System.Private.Uri/tests/FunctionalTests/UriParserTest.cs		diff \| blob \| history
src/libraries/System.Private.Uri/tests/FunctionalTests/UriTests.cs		diff \| blob \| history
src/libraries/System.Private.Xml.Linq/tests/SDMSample/SDMContainer.cs		diff \| blob \| history
src/libraries/System.Private.Xml.Linq/tests/SDMSample/SDMElement.cs		diff \| blob \| history
src/libraries/System.Private.Xml.Linq/tests/TreeManipulation/SaveWithFileName.cs		diff \| blob \| history
src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlDocument/XmlDocumentTests/CreateCommentTests.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlDocument/XmlElementTests/SetAttributeTests.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlDocument/XmlNamedNodeMapTests/GetNameTests.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlDocument/XmlNodeTests/LastChildTests.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlDocument/XmlNodeTests/LocalNameTests.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlNodeReader/System.Xml.XmlNodeReader.Tests/XmlNodeReaderMiscTests.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Add_Schema.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Add_SchemaSet.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Add_URL.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Contains_ns.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Contains_schema.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/Constructor_AddSchema.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/GetExpectedParticles.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/Initialize_EndValidation.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/PropertiesTests.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateAttribute.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateAttribute_String.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateElement.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateText_EndElement.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateText_String.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateWhitespace_String.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidatorModule.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.RuntimeOnly.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs		diff \| blob \| history
src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/OutputSettings.cs		diff \| blob \| history
src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineInitializedData.cs		diff \| blob \| history
src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderProviderTests.cs		diff \| blob \| history
src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs		diff \| blob \| history
src/libraries/System.Reflection.Metadata/tests/Utilities/BlobReaderTests.cs		diff \| blob \| history
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/MetadataLoadContext/ResolveMethod.cs		diff \| blob \| history
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeInvariants.cs		diff \| blob \| history
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.Get.CornerCases.cs		diff \| blob \| history
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs		diff \| blob \| history
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_MethodTests.cs		diff \| blob \| history
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_PropertyTests.cs		diff \| blob \| history
src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoInvokeArrayTests.cs		diff \| blob \| history
src/libraries/System.Reflection/tests/AssemblyTests.cs		diff \| blob \| history
src/libraries/System.Reflection/tests/ConstructorInfoTests.cs		diff \| blob \| history
src/libraries/System.Runtime.Caching/tests/AdditionalCacheTests/AdditionalCacheTests.cs		diff \| blob \| history
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs		diff \| blob \| history
src/libraries/System.Runtime.Extensions/tests/System/Convert.cs		diff \| blob \| history
src/libraries/System.Runtime.Extensions/tests/System/Environment.SetEnvironmentVariable.cs		diff \| blob \| history
src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests.cs		diff \| blob \| history
src/libraries/System.Runtime.Numerics/tests/BigInteger/parse.cs		diff \| blob \| history
src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs		diff \| blob \| history
src/libraries/System.Runtime.Serialization.Json/tests/DataContractJsonSerializer.cs		diff \| blob \| history
src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs		diff \| blob \| history
src/libraries/System.Runtime/tests/System/ArrayTests.cs		diff \| blob \| history
src/libraries/System.Runtime/tests/System/AttributeTests.cs		diff \| blob \| history
src/libraries/System.Runtime/tests/System/DelegateTests.cs		diff \| blob \| history
src/libraries/System.Runtime/tests/System/EntryPointNotFoundExceptionTests.cs		diff \| blob \| history
src/libraries/System.Runtime/tests/System/GCTests.cs		diff \| blob \| history
src/libraries/System.Runtime/tests/System/MulticastDelegateTests.cs		diff \| blob \| history
src/libraries/System.Runtime/tests/System/Reflection/TypeTests.Get.CornerCases.cs		diff \| blob \| history
src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/ConditionalWeakTableTests.netcoreapp.cs		diff \| blob \| history
src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs		diff \| blob \| history
src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs		diff \| blob \| history
src/libraries/System.Security.Cryptography.Xml/tests/KeyInfoTest.cs		diff \| blob \| history
src/libraries/System.Security.Cryptography.Xml/tests/KeyInfoX509DataTest.cs		diff \| blob \| history
src/libraries/System.Security.Cryptography.Xml/tests/XmlDsigC14NTransformTest.cs		diff \| blob \| history
src/libraries/System.Security.Cryptography.Xml/tests/XmlLicenseEncryptedRef.cs		diff \| blob \| history
src/libraries/System.Security.Cryptography.Xml/tests/XmlLicenseTransformTest.cs		diff \| blob \| history
src/libraries/System.Text.Encoding.Extensions/tests/Fallback.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/NewtonsoftTests/EnumConverterTests.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/NewtonsoftTests/ImmutableCollectionsTests.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/NewtonsoftTests/JsonSerializerTests.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/Serialization/CustomConverterTests.BadConverters.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/Serialization/DictionaryTests.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/Serialization/TestClasses.SimpleTestClassWithNullables.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/Serialization/TestClasses.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/Utf8JsonReaderTests.TryGet.cs		diff \| blob \| history
src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/ActionBlockTests.cs		diff \| blob \| history
src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/BroadcastBlockTests.cs		diff \| blob \| history
src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/WriteOnceBlockTests.cs		diff \| blob \| history
src/libraries/System.Threading.Tasks.Parallel/tests/RangePartitioner1Chunk.cs		diff \| blob \| history
src/libraries/System.Threading.Tasks/tests/AggregateExceptionTests.cs		diff \| blob \| history
src/libraries/System.Threading.Tasks/tests/Task/TaskRtTests_Core.cs		diff \| blob \| history
src/libraries/System.Threading/tests/AsyncLocalTests.cs		diff \| blob \| history
src/libraries/System.Transactions.Local/tests/AsyncTransactionScopeTests.cs		diff \| blob \| history
src/libraries/System.Transactions.Local/tests/CloneTxTests.cs		diff \| blob \| history
src/libraries/System.Transactions.Local/tests/LTMEnlistmentTests.cs		diff \| blob \| history
src/libraries/System.Transactions.Local/tests/NonMsdtcPromoterTests.cs		diff \| blob \| history
src/libraries/System.Transactions.Local/tests/TestEnlistments.cs		diff \| blob \| history
src/libraries/System.Transactions.Local/tests/TransactionScopeTest.cs		diff \| blob \| history

Domain: Dotnet / Core;

RSS Atom