i2c: designware-pci: Fix BUG_ON during device removal
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Thu, 13 Feb 2020 15:15:03 +0000 (17:15 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Tue, 10 Mar 2020 09:33:52 +0000 (10:33 +0100)
commit9be8bc4dd6177cf992b93b0bd014c4f611283896
tree4944934e47fbebf82864a29c6571a6105be31810
parent04bbb97d1b732b2d197f103c5818f5c214a4cf81
i2c: designware-pci: Fix BUG_ON during device removal

Function i2c_dw_pci_remove() -> pci_free_irq_vectors() ->
pci_disable_msi() -> free_msi_irqs() will throw a BUG_ON() for MSI
enabled device since the driver has not released the requested IRQ before
calling the pci_free_irq_vectors().

Here driver requests an IRQ using devm_request_irq() but automatic
release happens only after remove callback. Fix this by explicitly
freeing the IRQ before calling pci_free_irq_vectors().

Fixes: 21aa3983d619 ("i2c: designware-pci: Switch over to MSI interrupts")
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-designware-pcidrv.c