mesa: remove an optional GL error about mapped buffers during execution
authorMarek Olšák <marek.olsak@amd.com>
Mon, 25 Jan 2021 16:55:19 +0000 (11:55 -0500)
committerMarge Bot <eric+marge@anholt.net>
Mon, 15 Feb 2021 19:29:09 +0000 (19:29 +0000)
commit9bd4755410f767e8857ae928b12632d3a90634fc
tree730dca2989ea49f5c5086a30a7b5bf567edb49f0
parent7794305f0d7931691cf075f38cad8f1e68ea28c6
mesa: remove an optional GL error about mapped buffers during execution

Not having this here, even if the branch is not taken, increases
CPU performance by 2% on radeonsi. If some drivers need this, the spec
does allow GL termination, meaning abort(), which is a more effective
alternative given that this never happens.

You may ask, do we really pay a 2% performance hit for every conditional
not taken? For some of them, we do.

Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8798>
src/mesa/main/draw_validate.c
src/mesa/main/draw_validate.h
src/mesa/vbo/vbo_exec_api.c