[llvm] Revert r231274: "Devirtualize ~parser<T> by making it protected in base classe...
authorDon Hinton <hintonda@gmail.com>
Fri, 3 May 2019 16:15:13 +0000 (16:15 +0000)
committerDon Hinton <hintonda@gmail.com>
Fri, 3 May 2019 16:15:13 +0000 (16:15 +0000)
commit9bc070077efba53728de05769b803258f832b0d8
tree008db8feac090f79b75390a9f1d83977765adc16
parentb323d5ec7cac0122cbf6cd98d47119722f02163c
[llvm] Revert r231274: "Devirtualize ~parser<T> by making it protected in base classes and making derived classes final"

Summary: This patch was previously applied in r231221, and reverted in
r231254 because it broke self-hosting.  It was subsequently fixed and
reapplied in r231274.  Unfortunately, making the `parser<T>` classes
final prevents inheritance which makes it impossible to implement
custom parsers.

Reverting r231221 restores the ability to customize parsers.

Reviewers: dblaikie

Reviewed By: dblaikie

Subscribers: craig.topper, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D60955

llvm-svn: 359902
llvm/include/llvm/Support/CommandLine.h