net/l2tp: Fix reference count leak in l2tp_udp_recv_core
authorXiyu Yang <xiyuyang19@fudan.edu.cn>
Thu, 9 Sep 2021 04:32:00 +0000 (12:32 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 9 Sep 2021 10:00:20 +0000 (11:00 +0100)
commit9b6ff7eb666415e1558f1ba8a742f5db6a9954de
tree2961aada1fd30146e1b32903e13fa377e67069fe
parent04f08eb44b5011493d77b602fdec29ff0f5c6cd5
net/l2tp: Fix reference count leak in l2tp_udp_recv_core

The reference count leak issue may take place in an error handling
path. If both conditions of tunnel->version == L2TP_HDR_VER_3 and the
return value of l2tp_v3_ensure_opt_in_linear is nonzero, the function
would directly jump to label invalid, without decrementing the reference
count of the l2tp_session object session increased earlier by
l2tp_tunnel_get_session(). This may result in refcount leaks.

Fix this issue by decrease the reference count before jumping to the
label invalid.

Fixes: 4522a70db7aa ("l2tp: fix reading optional fields of L2TPv3")
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/l2tp/l2tp_core.c