drm/radeon: fix copy of uninitialized variable back to userspace
authorColin Ian King <colin.king@canonical.com>
Wed, 3 Mar 2021 00:27:59 +0000 (00:27 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 May 2021 07:50:01 +0000 (09:50 +0200)
commit9b50c185d27d232fa68e3382398bfae7d4d23f8f
tree70ccb97d223ebe356d4f29192a625fe0a3d25e9d
parent09b031b5fc18f28783e0cee5cf93e7831179aa0f
drm/radeon: fix copy of uninitialized variable back to userspace

commit 8dbc2ccac5a65c5b57e3070e36a3dc97c7970d96 upstream.

Currently the ioctl command RADEON_INFO_SI_BACKEND_ENABLED_MASK can
copy back uninitialised data in value_tmp that pointer *value points
to. This can occur when rdev->family is less than CHIP_BONAIRE and
less than CHIP_TAHITI.  Fix this by adding in a missing -EINVAL
so that no invalid value is copied back to userspace.

Addresses-Coverity: ("Uninitialized scalar variable)
Cc: stable@vger.kernel.org # 3.13+
Fixes: 439a1cfffe2c ("drm/radeon: expose render backend mask to the userspace")
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/radeon/radeon_kms.c