distcheck: don't allow overriding of --prefix and --srcdir by the user
authorStefano Lattarini <stefano.lattarini@gmail.com>
Wed, 30 Oct 2013 21:41:39 +0000 (21:41 +0000)
committerStefano Lattarini <stefano.lattarini@gmail.com>
Wed, 30 Oct 2013 22:26:01 +0000 (22:26 +0000)
commit9b156829b0ffac5e657b801b1f852608cfe8fc97
tree752fbdd07be990591130301f4ea9fd54e24be87b
parent608d1a7908893b2896f5efd2a4ed22d7901262ed
distcheck: don't allow overriding of --prefix and --srcdir by the user

Not through AM_DISTCHECK_FLAGS, nor through DISTCHECK_FLAGS.  Apparently,
some packages got in the habit of relaying all the options passed to the
original ./configure invocation through to the configure invocations
in "make distcheck".  This was causing problems, because it also passed
through the original --srcdir and --prefix options.

Fixes: expose bug#14991 (relates to 'distcheck')

* lib/am/distdir.am (distcheck): Pass the hard-coded --srcdir and
--prefix options *after* both the developer-defined options in
$(AM_DISTCHECK_FLAGS) and the user-defined options in $(DISTCHECK_FLAGS).
* t/list-of-tests.mk (XFAIL_TESTS): Remove the now-passing test
'distcheck-no-destdist-or-srcdir-override.sh'.
* doc/automake.texi (Checking the Distribution): Update.
* NEWS: Likewise.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
NEWS
doc/automake.texi
lib/am/distdir.am
t/list-of-tests.mk