Fix build on Windows, deprecate soup-portability.h
authorDan Winship <danw@gnome.org>
Fri, 19 Apr 2013 13:57:34 +0000 (09:57 -0400)
committerDan Winship <danw@gnome.org>
Fri, 19 Apr 2013 13:57:34 +0000 (09:57 -0400)
commit9b00583aabca2c7200189c8e40f34dda819c3e80
tree14529ca6d4a48e79b7496f21c588fa6d51afc873
parentce2043a7a81d2d8c9fba3b87a03df52df99e4115
Fix build on Windows, deprecate soup-portability.h

soup-portability.h created portability problems (ha!) because the
windows headers do "#define interface struct", conflicting with
variable names elsewhere.

The only thing that needed soup-portability.h in the public headers
was soup-address.h, which uses struct sockaddr. But we can just do a
forward declaration of that type rather than actually pulling in the
headers. Then soup-address.h can stop including soup-portability.h,
and we can use gio/gnetworking.h in the handful of other places that
need networking-related includes.

This may possibly break some other modules that depended on implicitly
getting network includes as a side effect of including soup.h...

https://bugzilla.gnome.org/show_bug.cgi?id=692134
libsoup/soup-address.c
libsoup/soup-address.h
libsoup/soup-socket.c
tests/connection-test.c
tests/socket-test.c