Don't retain modifiers for instantation stub signatures (dotnet/coreclr#23210)
authorAndy Ayers <andya@microsoft.com>
Tue, 12 Mar 2019 23:46:24 +0000 (16:46 -0700)
committerJan Kotas <jkotas@microsoft.com>
Tue, 12 Mar 2019 23:46:24 +0000 (16:46 -0700)
commit9af0b59bc920f2a60fc90eeabff55d630b8a6fcc
treeae438afb290ca93e57021ece63ce19f4ad28652e
parentcb2afc26a39ce04669135feca799d60665c89d13
Don't retain modifiers for instantation stub signatures (dotnet/coreclr#23210)

`ConvToJitSig` is not expecting to see modifiers for return types in sigs,
so don't bother preserving them when creating instantiation stubs.

This comes up for instantiation stubs for methods of `ReadOnlySpan<T>`.

Also, if we are preserving modifiers in a sig, make sure to prefix their type
handles with `ELEM_TYPE_INTERNAL`.

Fixes dotnet/coreclr#23136.

Commit migrated from https://github.com/dotnet/coreclr/commit/5831fe40394fcdc34fa161041956d379db433dd6
src/coreclr/src/vm/prestub.cpp
src/coreclr/src/vm/siginfo.cpp