media: rockchip/rga: Fix broken .start_streaming
authorEzequiel Garcia <ezequiel@collabora.com>
Fri, 1 Jun 2018 19:49:51 +0000 (15:49 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 28 Jun 2018 11:55:39 +0000 (07:55 -0400)
commit9aecc03555825a79a8a4ca45199cb866e8684623
tree3fb3730bf9a1a873780c6b0db5adb28417941d0c
parent1946117b8f135a62eea5cfa18be63b1741174b9f
media: rockchip/rga: Fix broken .start_streaming

Currently, rga_buf_start_streaming() is expecting
pm_runtime_get_sync to return zero on success, which
is wrong.

As per the documentation, pm_runtime_get_sync increments
the device's usage counter and return its result.
This means it will typically return a positive integer
on success and a negative error code.

Therefore, rockchip-rga driver is currently unusable
failing to start_streaming in most cases. Fix it and
while here, cleanup the buffer return-to-core logic.

Fixes: f7e7b48e6d79 ("[media] rockchip/rga: v4l2 m2m support")

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Reviewed-by: Jacob Chen <jacob-chen@iotwrt.com>
[hans.verkuil@cisco.com: fix line over 80 cols warning]
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/rockchip/rga/rga-buf.c