eeprom: at24: use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 29 May 2019 16:30:52 +0000 (11:30 -0500)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 31 May 2019 07:06:52 +0000 (09:06 +0200)
commit9ae9d9bfb72ce43ab5851da55dd17c5f64e87151
treeeae504ac76fc8b0dfcf8a24a002d1c285a554a51
parenta8806581241b69b3ae3199f47412c04de854c53a
eeprom: at24: use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);
instance = devm_kzalloc(dev, size, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

Notice that, in this case, variable at24_size is not necessary, hence it
is removed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/misc/eeprom/at24.c