sched/topology: Don't set SD_BALANCE_WAKE on cpuset domain relax
authorValentin Schneider <valentin.schneider@arm.com>
Mon, 14 Oct 2019 16:44:08 +0000 (17:44 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 17 Oct 2019 19:31:54 +0000 (21:31 +0200)
commit9ae7ab20b4835dbea0e5fc6a5c70171dc354a72e
tree92ef027044af03e7e59ada67df2cec9cc2c1653c
parent8d495477d62e4397207f22a432fcaa86d9f2bc2d
sched/topology: Don't set SD_BALANCE_WAKE on cpuset domain relax

As pointed out in commit

  182a85f8a119 ("sched: Disable wakeup balancing")

SD_BALANCE_WAKE is a tad too aggressive, and is usually left unset.

However, it turns out cpuset domain relaxation will unconditionally set it
on domains below the relaxation level. This made sense back when
SD_BALANCE_WAKE was set unconditionally, but it no longer is the case.

We can improve things slightly by noticing that set_domain_attribute() is
always called after sd_init(), so rather than setting flags we can rely on
whatever sd_init() is doing and only clear certain flags when above the
relaxation level.

While at it, slightly clean up the function and flip the relax level
check to be more human readable.

Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: mingo@kernel.org
Cc: vincent.guittot@linaro.org
Cc: juri.lelli@redhat.com
Cc: seto.hidetoshi@jp.fujitsu.com
Cc: qperret@google.com
Cc: Dietmar.Eggemann@arm.com
Cc: morten.rasmussen@arm.com
Link: https://lkml.kernel.org/r/20191014164408.32596-1-valentin.schneider@arm.com
kernel/sched/topology.c