platform/chrome: cros_ec_typec: zero out stale pointers
authorVictor Ding <victording@chromium.org>
Wed, 7 Dec 2022 09:39:40 +0000 (09:39 +0000)
committerTzung-Bi Shih <tzungbi@kernel.org>
Thu, 8 Dec 2022 01:44:48 +0000 (09:44 +0800)
commit9a8aadcf0b459c1257b9477fd6402e1d5952ae07
tree0ab55fc9e54665a80f8820213849339fee1b8d78
parent5a2d96623670155d94aca72c320c0ac27bdc6bd2
platform/chrome: cros_ec_typec: zero out stale pointers

`cros_typec_get_switch_handles` allocates four pointers when obtaining
type-c switch handles. These pointers are all freed if failing to obtain
any of them; therefore, pointers in `port` become stale. The stale
pointers eventually cause use-after-free or double free in later code
paths. Zeroing out all pointer fields after freeing to eliminate these
stale pointers.

Fixes: f28adb41dab4 ("platform/chrome: cros_ec_typec: Register Type C switches")
Fixes: 1a8912caba02 ("platform/chrome: cros_ec_typec: Get retimer handle")
Signed-off-by: Victor Ding <victording@chromium.org>
Acked-by: Prashant Malani <pmalani@chromium.org>
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20221207093924.v2.1.I1864b6a7ee98824118b93677868d22d3750f439b@changeid
drivers/platform/chrome/cros_ec_typec.c