remove automatic splitting from $$() expansions
authorOswald Buddenhagen <oswald.buddenhagen@digia.com>
Thu, 16 May 2013 15:19:06 +0000 (17:19 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Tue, 21 May 2013 12:43:07 +0000 (14:43 +0200)
commit9a36904e158d85f86155bf07c9038988e46461ae
tree794f96541b44f6dba51b3babc906c1158a419ac6
parent8591d77fa6d3383c07c373970e59362ff16b143f
remove automatic splitting from $$() expansions

$$(FOO) would automatically split the contents of the environment
variable at whitespace (and interpret quoting inside it). the way to
prevent the splitting (but not the quote interpretation) would be using
"$$(FOO)".

this behavior is entirely unexpected and thus an incredibly effective
source of quoting problems - according to a grep over the whole qt
sources, there isn't a single case where things were done right. in qt
creator, well over half the cases are wrong.

also, the "feature" seems entirely pointless: nobody uses spaces as
separators in environment variables.

consequently, simply remove it, even in a patch release. i'm postulating
that nobody will complain.

Change-Id: I9ed3df1b0d1ef602acd78ceb118611d294561da6
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
(cherry picked from qtbase/566d28316dd73bfe4a8ea34839989ee9df7e3895)
src/linguist/shared/qmakeevaluator.cpp