mm: remove gup_flags FOLL_WRITE games from __get_user_pages() 69/94469/1 accepted/tizen/common/20161031.122108 accepted/tizen/ivi/20161101.005239 accepted/tizen/mobile/20161101.005146 accepted/tizen/tv/20161101.005159 accepted/tizen/wearable/20161101.005219 submit/tizen/20161031.063553 submit/tizen/20161031.074716
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 13 Oct 2016 20:07:36 +0000 (13:07 -0700)
committerInki Dae <inki.dae@samsung.com>
Mon, 31 Oct 2016 05:29:22 +0000 (14:29 +0900)
commit9a22ee15db74100dea7c7ab6ab2233c7197c0e34
tree84015b62689b262c15d00f917c605dd400203390
parent4f59c171e638b25a38db2c56a41254f5a63eba0b
mm: remove gup_flags FOLL_WRITE games from __get_user_pages()

[ Upstream commit 19be0eaffa3ac7d8eb6784ad9bdbc7d67ed8e619 ]

This is an ancient bug that was actually attempted to be fixed once
(badly) by me eleven years ago in commit 4ceb5db9757a ("Fix
get_user_pages() race for write access") but that was then undone due to
problems on s390 by commit f33ea7f404e5 ("fix get_user_pages bug").

In the meantime, the s390 situation has long been fixed, and we can now
fix it by checking the pte_dirty() bit properly (and do it better).  The
s390 dirty bit was implemented in abf09bed3cce ("s390/mm: implement
software dirty bits") which made it into v3.9.  Earlier kernels will
have to look at the page state itself.

Also, the VM has become more scalable, and what used a purely
theoretical race back then has become easier to trigger.

To fix it, we introduce a new internal FOLL_COW flag to mark the "yes,
we already did a COW" rather than play racy games with FOLL_WRITE that
is very fundamental, and then use the pte dirty flag to validate that
the FOLL_COW flag is still valid.

Change-Id: Id6048418817ef29d04bf4e2a5c4e39ece812be81
Reported-and-tested-by: Phil "not Paul" Oester <kernel@linuxace.com>
Acked-by: Hugh Dickins <hughd@google.com>
Reviewed-by: Michal Hocko <mhocko@suse.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Willy Tarreau <w@1wt.eu>
Cc: Nick Piggin <npiggin@gmail.com>
Cc: Greg Thelen <gthelen@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
include/linux/mm.h
mm/gup.c