ethtool: linkstate: add a statistic for PHY down events
authorJakub Kicinski <kuba@kernel.org>
Fri, 4 Nov 2022 19:01:25 +0000 (12:01 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 8 Nov 2022 09:36:54 +0000 (10:36 +0100)
commit9a0f830f80265bd1ef816e1541ac24bee80e9a3c
tree6b133c57ec859a96c27e2a06c9f80405c448b540
parent91c596cc8d321cd00b8782a2b16772a033a0adf8
ethtool: linkstate: add a statistic for PHY down events

The previous attempt to augment carrier_down (see Link)
was not met with much enthusiasm so let's do the simple
thing of exposing what some devices already maintain.
Add a common ethtool statistic for link going down.
Currently users have to maintain per-driver mapping
to extract the right stat from the vendor-specific ethtool -S
stats. carrier_down does not fit the bill because it counts
a lot of software related false positives.

Add the statistic to the extended link state API to steer
vendors towards implementing all of it.

Implement for bnxt and all Linux-controlled PHYs. mlx5 and (possibly)
enic also have a counter for this but I leave the implementation
to their maintainers.

Link: https://lore.kernel.org/r/20220520004500.2250674-1-kuba@kernel.org
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20221104190125.684910-1-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Documentation/networking/ethtool-netlink.rst
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
drivers/net/phy/phy.c
include/linux/ethtool.h
include/linux/phy.h
include/uapi/linux/ethtool_netlink.h
net/ethtool/linkstate.c