net: systemport: Fix ordering in intrl2_*_mask_clear macro
authorFlorian Fainelli <f.fainelli@gmail.com>
Wed, 24 Aug 2016 21:21:41 +0000 (14:21 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 25 Aug 2016 23:52:44 +0000 (16:52 -0700)
commit9a0a5c4cb1af98b625dcefd72e987ca4929db71d
tree3f3e05f8206d766a367779e669d0c146ed910f18
parenteb60a8ddf3c38959cc73821bec5335bed85e0200
net: systemport: Fix ordering in intrl2_*_mask_clear macro

Since we keep shadow copies of which interrupt sources are enabled
through the intrl2_*_mask_{set,clear} macros, make sure that the
ordering in which we do these two operations: update the copy, then
unmask the register is correct.

This is not currently a problem because we actually do not use them, but
we will in a subsequent patch optimizing register accesses, so better be
safe here.

Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bcmsysport.c