ipv4: Fix potential uninit variable access bug in __ip_make_skb()
authorZiyang Xuan <william.xuanziyang@huawei.com>
Thu, 20 Apr 2023 12:40:35 +0000 (20:40 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 22 Apr 2023 13:10:39 +0000 (14:10 +0100)
commit99e5acae193e369b71217efe6f1dad42f3f18815
tree4828ad5ceece8950a4e12ba57a0667f1d4a2b0d0
parent6e79bd28ab0abd7e82d020d6d1728c3ca543450f
ipv4: Fix potential uninit variable access bug in __ip_make_skb()

Like commit ea30388baebc ("ipv6: Fix an uninit variable access bug in
__ip6_make_skb()"). icmphdr does not in skb linear region under the
scenario of SOCK_RAW socket. Access icmp_hdr(skb)->type directly will
trigger the uninit variable access bug.

Use a local variable icmp_type to carry the correct value in different
scenarios.

Fixes: 96793b482540 ("[IPV4]: Add ICMPMsgStats MIB (RFC 4293)")
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_output.c