powerpc/spufs: Fix coredump of SPU contexts
authorMichael Ellerman <mpe@ellerman.id.au>
Mon, 29 May 2017 10:26:07 +0000 (20:26 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 1 Jun 2017 09:54:40 +0000 (19:54 +1000)
commit99acc9bede06bbb2662aafff51f5b9e529fa845e
tree4c8ee57d363423843dbe5d4ffd2057f711a8ebed
parenta2b05b7aa60e1e9b60faf01dfb1cca35638d1ab1
powerpc/spufs: Fix coredump of SPU contexts

If a process dumps core while it has SPU contexts active then we have
code to also dump information about the SPU contexts.

Unfortunately it's been broken for 3 1/2 years, and we didn't notice. In
commit 7b1f4020d0d1 ("spufs: get rid of dump_emit() wrappers") the nread
variable was removed and rc used instead. That means when the loop exits
successfully, rc has the number of bytes read, but it's then used as the
return value for the function, which should return 0 on success.

So fix it by setting rc = 0 before returning in the success case.

Fixes: 7b1f4020d0d1 ("spufs: get rid of dump_emit() wrappers")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/cell/spufs/coredump.c