[OpenMP] set_bits iterator yields unsigned elements, no reference (NFC).
authorFlorian Hahn <flo@fhahn.com>
Sun, 29 Mar 2020 16:05:29 +0000 (17:05 +0100)
committerFlorian Hahn <flo@fhahn.com>
Sun, 29 Mar 2020 16:08:13 +0000 (17:08 +0100)
commit99913ef3d14fcbfc939d9547506b55ac76fd0c59
tree75068e77233c10dd42ab6a4c00c22e7f9e601a00
parent28f67bd5c56ba9c466b1fef600923483a967aa97
[OpenMP] set_bits iterator yields unsigned elements, no reference (NFC).

BitVector::set_bits() returns an iterator range yielding unsinged
elements, which always will be copied while const & gives the impression
that there will be no copy. Newer version of clang complain:

    warning: loop variable 'SetBitsIt' is always a copy because the range of type 'iterator_range<llvm::BitVector::const_set_bits_iterator>' (aka 'iterator_range<const_set_bits_iterator_impl<llvm::BitVector> >') does not return a reference [-Wrange-loop-analysis]

Reviewers: jdoerfert, rnk

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D77010
llvm/lib/Frontend/OpenMP/OMPContext.cpp