tracing: Fix trace_event_raw_event_synth() if else statement
authorSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 31 Jan 2023 14:52:37 +0000 (09:52 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 7 Feb 2023 17:48:58 +0000 (12:48 -0500)
commit9971c3f944489ff7aacb9d25e0cde841a5f6018a
tree29368ade7ba13715761d3cb43409b27c4967be7d
parentaef70ebd624cf2959c531b652365da83f2b19352
tracing: Fix trace_event_raw_event_synth() if else statement

The test to check if the field is a stack is to be done if it is not a
string. But the code had:

    } if (event->fields[i]->is_stack) {

and not

   } else if (event->fields[i]->is_stack) {

which would cause it to always be tested. Worse yet, this also included an
"else" statement that was only to be called if the field was not a string
and a stack, but this code allows it to be called if it was a string (and
not a stack).

Also fixed some whitespace issues.

Link: https://lore.kernel.org/all/202301302110.mEtNwkBD-lkp@intel.com/
Link: https://lore.kernel.org/linux-trace-kernel/20230131095237.63e3ca8d@gandalf.local.home
Cc: Tom Zanussi <zanussi@kernel.org>
Fixes: 00cf3d672a9d ("tracing: Allow synthetic events to pass around stacktraces")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
kernel/trace/trace_events_synth.c