ASoC: soc-dapm.c: merge dapm_power_one_widget() and dapm_widget_set_power()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Wed, 19 Oct 2022 00:36:51 +0000 (00:36 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 19 Oct 2022 12:05:30 +0000 (13:05 +0100)
commit9941ba4baed0a4388028e2ce3ff769d50324068a
tree6a1edb1b1c85e0c20f04d89830a512485402af97
parent2e3fafbb14300212d056d1ad2163bb38453be069
ASoC: soc-dapm.c: merge dapm_power_one_widget() and dapm_widget_set_power()

dapm_widget_set_power() (= X) is called only from
dapm_power_one_widget() (= Y), and total purpose of these functions are
calling dapm_seq_insert() (= a) accordingly for each widget.

(X) static void dapm_widget_set_power(...)
{
...
if (power)
(a) dapm_seq_insert(w, up_list, true);
else
(a) dapm_seq_insert(w, down_list, false);
}

(Y) static void dapm_power_one_widget(...)
{
..

switch (w->id) {
case snd_soc_dapm_pre:
(a) dapm_seq_insert(w, down_list, false);
break;
case snd_soc_dapm_post:
(a) dapm_seq_insert(w, up_list, true);
break;

default:
power = dapm_widget_power_check(w);

(X) dapm_widget_set_power(w, power, up_list, down_list);
break;
}
}

It should be more simple, but the code is unnecessarily complicated,
and difficult to read/understand. This patch merge these into one.

Link: https://lore.kernel.org/all/87tu42owdd.wl-kuninori.morimoto.gx@renesas.com/
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/8735bktzrx.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-dapm.c