net/ncsi: prevent a couple array underflows
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 17 May 2018 12:33:36 +0000 (15:33 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 May 2018 20:27:39 +0000 (16:27 -0400)
commit990a9d4975c974b05a8abaaeca5bbcfc55d31dcb
tree3e48d9e97348059ec69c00a807df5a3451c4b3ae
parentbe7f3e59997b7744e8be153b76fca28ac5b71354
net/ncsi: prevent a couple array underflows

We recently refactored this code and introduced a static checker
warning.  Smatch complains that if cmd->index is zero then we would
underflow the arrays.  That's obviously true.

The question is whether we prevent cmd->index from being zero at a
different level.  I've looked at the code and I don't immediately see
a check for that.

Fixes: 062b3e1b6d4f ("net/ncsi: Refactor MAC, VLAN filters")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ncsi/ncsi-rsp.c