SkPDF: Add sk_sp setters; .release() becomes std::move()
authorhalcanary <halcanary@google.com>
Tue, 8 Mar 2016 20:38:22 +0000 (12:38 -0800)
committerCommit bot <commit-bot@chromium.org>
Tue, 8 Mar 2016 20:38:22 +0000 (12:38 -0800)
commit9904c9212074279380e21f96575078734dbbd308
tree8970a1405170db6036b11ec1797e21cf33d5ce4b
parent6b5c5cc7b7bdffb4882706b915b544aba8714961
SkPDF: Add sk_sp setters; .release() becomes std::move()

Note to reviewers:  Start with changes to SkPDFTypes.h

Many places that had a bare pointer owning a reference are refactored to
use a sk_sp.

There remain several places where a non-owning pointer `T*` should be
replaced with `const sk_sp<T>&` to eliminate the common pattern
`sk_sp<T>(SkRef(x))`.

Review URL: https://codereview.chromium.org/1775043002
15 files changed:
src/doc/SkDocument_PDF.cpp
src/pdf/SkPDFBitmap.cpp
src/pdf/SkPDFDevice.cpp
src/pdf/SkPDFDevice.h
src/pdf/SkPDFFont.cpp
src/pdf/SkPDFFormXObject.cpp
src/pdf/SkPDFGraphicState.cpp
src/pdf/SkPDFResourceDict.cpp
src/pdf/SkPDFResourceDict.h
src/pdf/SkPDFShader.cpp
src/pdf/SkPDFTypes.cpp
src/pdf/SkPDFTypes.h
src/pdf/SkPDFUtils.cpp
src/pdf/SkPDFUtils.h
tests/PDFPrimitivesTest.cpp